Throw InvalidStateError when calling play() on a finished, reversed, infinite duration animation#475
Merged
suzyh merged 2 commits intoweb-animations:masterfrom Jul 27, 2016
alancutter:throwReversePlayInfiniteDuration
Merged
Throw InvalidStateError when calling play() on a finished, reversed, infinite duration animation#475suzyh merged 2 commits intoweb-animations:masterfrom alancutter:throwReversePlayInfiniteDuration
suzyh merged 2 commits intoweb-animations:masterfrom
alancutter:throwReversePlayInfiniteDuration
Conversation
| this._paused = false; | ||
| if (this._isFinished || this._idle) { | ||
| this._currentTime = this._playbackRate > 0 ? 0 : this._totalDuration; | ||
| if (this._playbackRate >= 0) { |
Contributor
There was a problem hiding this comment.
Is it significant that this has gone from > 0 to >= 0?
Contributor
Author
There was a problem hiding this comment.
It kind of emulates the part in the spec that says "Set animation’s hold time to zero." when we don't really have the concept of a hold time here.
Contributor
|
Given that this has caused the finished play state tests to go backwards, I'm reluctant to merge this until it's clear that that can be fixed. |
Contributor
Author
|
finish() was already broken. |
Contributor
|
ack, lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant spec section:
https://w3c.github.io/web-animations/#playing-an-animation-section